Skip to content

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jan 27, 2021

Roll back the component tests that were renabled in 3f7b205#diff-161948171825dc8c1b30fdc7c517d8e960d462359d1959cd30aa428ad16172f2

@HaoK HaoK requested a review from a team as a code owner January 27, 2021 01:06
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jan 27, 2021
@HaoK
Copy link
Member Author

HaoK commented Jan 27, 2021

EventDuringBatchRendering_CanTriggerDOMEvents()
BubblingStandardEvent_FiredOnElementWithoutHandler
CanUploadAndConvertImageFile

These have already failing again since they were unquarantined

@HaoK HaoK requested a review from a team January 27, 2021 19:48
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's try this.

@TanayParikh please keep an eye out for additional tests we may need to quarantine in this area in particular.

@TanayParikh
Copy link
Contributor

Sure, let's try this.

@TanayParikh please keep an eye out for additional tests we may need to quarantine in this area in particular.

Sounds good. @HaoK is this fine to merge now?

@BrennanConroy
Copy link
Member

Have you reopened all the linked issues?

@ghost

This comment has been minimized.

@HaoK
Copy link
Member Author

HaoK commented Jan 27, 2021

I'll create a new master issue and link them all to this one for now

@ghost
Copy link

ghost commented Jan 27, 2021

Hi @HaoK. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@HaoK HaoK mentioned this pull request Jan 27, 2021
7 tasks
@HaoK
Copy link
Member Author

HaoK commented Jan 27, 2021

#29698

@ghost
Copy link

ghost commented Jan 27, 2021

Hi @HaoK. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants